Commit c1fe3e98 authored Sep 25, 2017 by Chao Yu Committed by Jaegeuk Kim Oct 10, 2017

Revert "f2fs: reuse nids more aggressively"



Commit 26834466 ("f2fs: reuse nids more aggressively") tries to
reuse nids as many as possilbe, in order to mitigate producing obsolete
node pages in page cache.

But acutally, before we reuse the nids and related node page cache,
we will always invalidate that node page, so there will be not any
obsolete node pages in cache.

Let's just revert previous commit, so that nm_i::next_scan_nid can be
increased ascendingly, making __build_free_nids traverses all NAT pages
more easily, finally, free nid bitmap cache can be enabled as soon as
possible.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent 91f4382b

fs/f2fs/node.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -327,10 +327,6 @@ static void set_node_addr(struct f2fs_sb_info sbi, struct node_info ni,
		if (nat_get_blkaddr(e) != NEW_ADDR && new_blkaddr == NULL_ADDR) {
		unsigned char version = nat_get_version(e);
		nat_set_version(e, inc_node_version(version));

		/* in order to reuse the nid */
		if (nm_i->next_scan_nid > ni->nid)
		nm_i->next_scan_nid = ni->nid;
		}

		/* change address */

Admin message