Commit c1fd7bb9 authored Nov 12, 2013 by Joe Perches Committed by Linus Torvalds Nov 13, 2013

checkpatch: make the memory barrier test noisier



Peter Zijlstra prefers that comments be required near uses of memory
barriers.

Change the message level for memory barrier uses from a --strict test only
to a normal WARN so it's always emitted.

This might produce false positives around insertions of memory barriers
when a comment is outside the patch context block.

And checkpatch is still stupid, it only looks for existence of any
comment, not at the comment content.

Signed-off-by: Joe Perches <joe@perches.com>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e970b884

scripts/checkpatch.pl

+2 −2

Original line number	Diff line number	Diff line
		@@ -3850,7 +3850,7 @@ sub process {
		# check for memory barriers without a comment.
		if ($line =~ /\b(mb\|rmb\|wmb\|read_barrier_depends\|smp_mb\|smp_rmb\|smp_wmb\|smp_read_barrier_depends)\(/) {
		if (!ctx_has_comment($first_line, $linenr)) {
		CHK("MEMORY_BARRIER",
		WARN("MEMORY_BARRIER",
		"memory barrier without comment\n" . $herecurr);
		}
		}

Admin message