Commit c1fbb258 authored Apr 30, 2014 by Eliad Peller Committed by Johannes Berg May 05, 2014

cfg80211: free sme on connection failures



cfg80211 is notified about connection failures by
__cfg80211_connect_result() call. However, this
function currently does not free cfg80211 sme.

This results in hanging connection attempts in some cases

e.g. when mac80211 authentication attempt is denied,
we have this function call:
ieee80211_rx_mgmt_auth() -> cfg80211_rx_mlme_mgmt() ->
cfg80211_process_auth() -> cfg80211_sme_rx_auth() ->
__cfg80211_connect_result()

but cfg80211_sme_free() is never get called.

Fixes: ceca7b71 ("cfg80211: separate internal SME implementation")
Cc: stable@vger.kernel.org (3.10+)
Signed-off-by: Eliad Peller <eliadx.peller@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent f4ebddf9

net/wireless/sme.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -234,7 +234,6 @@ void cfg80211_conn_work(struct work_struct *work)
		NULL, 0, NULL, 0,
		WLAN_STATUS_UNSPECIFIED_FAILURE,
		false, NULL);
		cfg80211_sme_free(wdev);
		}
		wdev_unlock(wdev);
		}
		@@ -648,6 +647,7 @@ void __cfg80211_connect_result(struct net_device dev, const u8 bssid,
		cfg80211_unhold_bss(bss_from_pub(bss));
		cfg80211_put_bss(wdev->wiphy, bss);
		}
		cfg80211_sme_free(wdev);
		return;
		}

Admin message