microblaze: Fix sparse warnings - ptrace (c1df53b3) · Commits · 戴 / test

Warning log: CHECK arch/microblaze/kernel/ptrace.c arch/microblaze/kernel/ptrace.c:126:11: warning: incorrect type in initializer (different address spaces) arch/microblaze/kernel/ptrace.c:126:11: expected unknown type 2[noderef] *__pu_addr<asn:1> arch/microblaze/kernel/ptrace.c:126:11: got unsigned long *<noident> arch/microblaze/kernel/ptrace.c:134:17: warning: symbol 'do_syscall_trace_enter' was not declared. Should it be static? arch/microblaze/kernel/ptrace.c:157:17: warning: symbol 'do_syscall_trace_leave' was not declared. Should it be static? Signed-off-by:

Michal Simek <monstr@monstr.eu>

arch/microblaze/include/asm/syscall.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -96,4 +96,7 @@ static inline void syscall_set_arguments(struct task_struct *task,
		microblaze_set_syscall_arg(regs, i++, *args++);
		}

		asmlinkage long do_syscall_trace_enter(struct pt_regs *regs);
		asmlinkage void do_syscall_trace_leave(struct pt_regs *regs);

		#endif /* __ASM_MICROBLAZE_SYSCALL_H */

arch/microblaze/kernel/ptrace.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -39,6 +39,7 @@
		#include <linux/uaccess.h>
		#include <asm/asm-offsets.h>
		#include <asm/cacheflush.h>
		#include <asm/syscall.h>
		#include <asm/io.h>

		/* Returns the address where the register at REG_OFFS in P is stashed away. */
		@@ -123,7 +124,7 @@ long arch_ptrace(struct task_struct *child, long request,
		rval = -EIO;

		if (rval == 0 && request == PTRACE_PEEKUSR)
		rval = put_user(val, (unsigned long *)data);
		rval = put_user(val, (unsigned long __user *)data);
		break;
		default:
		rval = ptrace_request(child, request, addr, data);

Admin message