Commit c1d869d6 authored Jun 21, 2020 by Mark Zhang Committed by Jason Gunthorpe Jun 22, 2020

RDMA/counter: Query a counter before release

Query a dynamically-allocated counter before release it, to update it's
hwcounters and log all of them into history data. Otherwise all values of
these hwcounters will be lost.

Fixes: f34a55e4 ("RDMA/core: Get sum value of all counters when perform a sysfs stat read")
Link: https://lore.kernel.org/r/20200621110000.56059-1-leon@kernel.org


Signed-off-by: Mark Zhang <markz@mellanox.com>
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent a17f4bed

drivers/infiniband/core/counters.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -202,7 +202,7 @@ static int __rdma_counter_unbind_qp(struct ib_qp *qp)
		return ret;
		}

		static void counter_history_stat_update(const struct rdma_counter *counter)
		static void counter_history_stat_update(struct rdma_counter *counter)
		{
		struct ib_device *dev = counter->device;
		struct rdma_port_counter *port_counter;
		@@ -212,6 +212,8 @@ static void counter_history_stat_update(const struct rdma_counter *counter)
		if (!port_counter->hstats)
		return;

		rdma_counter_query_stats(counter);

		for (i = 0; i < counter->stats->num_counters; i++)
		port_counter->hstats->value[i] += counter->stats->value[i];
		}

Admin message