Commit c1d40a52 authored by Martin K. Petersen's avatar Martin K. Petersen Committed by Christoph Hellwig
Browse files

scsi: add a blacklist flag which enables VPD page inquiries 



Despite supporting modern SCSI features some storage devices continue to
claim conformance to an older version of the SPC spec. This is done for
compatibility with legacy operating systems.

Linux by default will not attempt to read VPD pages on devices that
claim SPC-2 or older. Introduce a blacklist flag that can be used to
trigger VPD page inquiries on devices that are known to support them.

Reported-by: default avatarKY Srinivasan <kys@microsoft.com>
Tested-by: default avatarKY Srinivasan <kys@microsoft.com>
Reviewed-by: default avatarKY Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
CC: <stable@vger.kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent fd2eb903

drivers/scsi/scsi_scan.c

+3 −1
Original line number Diff line number Diff line
@@ -928,7 +928,9 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result, 


	sdev->eh_timeout = SCSI_DEFAULT_EH_TIMEOUT;



	if (*bflags & BLIST_SKIP_VPD_PAGES)

	if (*bflags & BLIST_TRY_VPD_PAGES)

		sdev->try_vpd_pages = 1;

	else if (*bflags & BLIST_SKIP_VPD_PAGES)

		sdev->skip_vpd_pages = 1;



	transport_configure_device(&sdev->sdev_gendev);

drivers/scsi/sd.c

+5 −0
Original line number Diff line number Diff line
@@ -2726,6 +2726,11 @@ static void sd_read_write_same(struct scsi_disk *sdkp, unsigned char *buffer) 


static int sd_try_extended_inquiry(struct scsi_device *sdp)

{

	/* Attempt VPD inquiry if the device blacklist explicitly calls

	 * for it.

	 */

	if (sdp->try_vpd_pages)

		return 1;

	/*

	 * Although VPD inquiries can go to SCSI-2 type devices,

	 * some USB ones crash on receiving them, and the pages

include/scsi/scsi_device.h

+1 −0
Original line number Diff line number Diff line
@@ -154,6 +154,7 @@ struct scsi_device { 
	unsigned skip_ms_page_8:1;	/* do not use MODE SENSE page 0x08 */

	unsigned skip_ms_page_3f:1;	/* do not use MODE SENSE page 0x3f */

	unsigned skip_vpd_pages:1;	/* do not read VPD pages */

	unsigned try_vpd_pages:1;	/* attempt to read VPD pages */

	unsigned use_192_bytes_for_3f:1; /* ask for 192 bytes from page 0x3f */

	unsigned no_start_on_add:1;	/* do not issue start on add */

	unsigned allow_restart:1; /* issue START_UNIT in error handler */

include/scsi/scsi_devinfo.h

+1 −0
Original line number Diff line number Diff line
@@ -34,4 +34,5 @@ 
#define BLIST_SKIP_VPD_PAGES	0x4000000 /* Ignore SBC-3 VPD pages */

#define BLIST_SCSI3LUN		0x8000000 /* Scan more than 256 LUNs

					     for sequential scan */

#define BLIST_TRY_VPD_PAGES	0x10000000 /* Attempt to read VPD pages */

#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE