Commit c19f9a84 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI / Button: Avoid disabling wakeup unnecessarily on remove 



If a button device had already been enabled to wake up the system
from sleep states before the button driver saw it, the driver
shouldn't disable the device's wakeup capability when being detached
from the device.

Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
parent 51907267

drivers/acpi/button.c

+7 −2
Original line number Diff line number Diff line
@@ -98,6 +98,7 @@ struct acpi_button { 
	struct input_dev *input;

	char phys[32];			/* for input device */

	unsigned long pushed;

	bool wakeup_enabled;

};



static const struct file_operations acpi_button_info_fops = {
@@ -430,7 +431,10 @@ static int acpi_button_add(struct acpi_device *device) 
		/* Button's GPE is run-wake GPE */

		acpi_enable_gpe(device->wakeup.gpe_device,

				device->wakeup.gpe_number);

		if (!device_may_wakeup(&device->dev)) {

			device_set_wakeup_enable(&device->dev, true);

			button->wakeup_enabled = true;

		}

	}



	printk(KERN_INFO PREFIX "%s [%s]\n", name, acpi_device_bid(device));
@@ -452,6 +456,7 @@ static int acpi_button_remove(struct acpi_device *device, int type) 
	if (device->wakeup.flags.valid) {

		acpi_disable_gpe(device->wakeup.gpe_device,

				device->wakeup.gpe_number);

		if (button->wakeup_enabled)

			device_set_wakeup_enable(&device->dev, false);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE