Commit c189a685 authored Oct 25, 2015 by Andrei Otcheretianski Committed by Johannes Berg Nov 03, 2015

mac80211: Remove WARN_ON_ONCE in ieee80211_recalc_smps



The recalc_smps work can run after the station disassociates.
At this stage we already released the channel, but the work
will be cancelled only when the interface stops.
In this scenario we can hit the warning in ieee80211_recalc_smps, so
just remove it.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 43d6df00

net/mac80211/util.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -2151,7 +2151,13 @@ void ieee80211_recalc_smps(struct ieee80211_sub_if_data *sdata)
		chanctx_conf = rcu_dereference_protected(sdata->vif.chanctx_conf,
		lockdep_is_held(&local->chanctx_mtx));

		if (WARN_ON_ONCE(!chanctx_conf))
		/*
		* This function can be called from a work, thus it may be possible
		* that the chanctx_conf is removed (due to a disconnection, for
		* example).
		* So nothing should be done in such case.
		*/
		if (!chanctx_conf)
		goto unlock;

		chanctx = container_of(chanctx_conf, struct ieee80211_chanctx, conf);

Admin message