Commit c180d710 authored May 06, 2019 by Dan Carpenter Committed by Olof Johansson May 16, 2019

soc: ixp4xx: qmgr: Fix an NULL vs IS_ERR() check in probe



The devm_ioremap_resource() function doesn't retunr NULL, it returns
error pointers.

Fixes: ecc133c6 ("soc: ixp4xx: qmgr: Pass resources")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>

parent ab02888e

drivers/soc/ixp4xx/ixp4xx-qmgr.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -385,8 +385,8 @@ static int ixp4xx_qmgr_probe(struct platform_device *pdev)
		if (!res)
		return -ENODEV;
		qmgr_regs = devm_ioremap_resource(dev, res);
		if (!qmgr_regs)
		return -ENOMEM;
		if (IS_ERR(qmgr_regs))
		return PTR_ERR(qmgr_regs);

		irq1 = platform_get_irq(pdev, 0);
		if (irq1 <= 0)

Admin message