powerpc: Make setjmp/longjmp signature standard (c17eb4dc) · Commits · 戴 / test

Declaring setjmp()/longjmp() as taking longs makes the signature non-standard, and makes clang complain. In the past, this has been worked around by adding -ffreestanding to the compile flags. The implementation looks like it only ever propagates the value (in longjmp) or sets it to 1 (in setjmp), and we only call longjmp with integer parameters. This allows removing -ffreestanding from the compilation flags. Fixes: ("powerpc: Avoid clang warnings around setjmp and longjmp") Cc: stable@vger.kernel.org # v4.14+ Signed-off-by:

Clement Courbet <courbet@google.com> Reviewed-by:

Nathan Chancellor <natechancellor@gmail.com> Tested-by:

Nathan Chancellor <natechancellor@gmail.com> Signed-off-by:

Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20200330080400.124803-1-courbet@google.com

arch/powerpc/include/asm/setjmp.h

+4 −2

Original line number	Diff line number	Diff line
		@@ -7,7 +7,9 @@

		#define JMP_BUF_LEN 23

		extern long setjmp(long *) __attribute__((returns_twice));
		extern void longjmp(long *, long) __attribute__((noreturn));
		typedef long jmp_buf[JMP_BUF_LEN];

		extern int setjmp(jmp_buf env) __attribute__((returns_twice));
		extern void longjmp(jmp_buf env, int val) __attribute__((noreturn));

		#endif /* _ASM_POWERPC_SETJMP_H */

arch/powerpc/kexec/Makefile

+0 −3

Original line number	Diff line number	Diff line
		@@ -3,9 +3,6 @@
		# Makefile for the linux kernel.
		#

		# Avoid clang warnings around longjmp/setjmp declarations
		CFLAGS_crash.o += -ffreestanding

		obj-y += core.o crash.o core_$(BITS).o

		obj-$(CONFIG_PPC32) += relocate_32.o

arch/powerpc/xmon/Makefile

+0 −3

Original line number	Diff line number	Diff line
		# SPDX-License-Identifier: GPL-2.0
		# Makefile for xmon

		# Avoid clang warnings around longjmp/setjmp declarations
		subdir-ccflags-y := -ffreestanding

		GCOV_PROFILE := n
		KCOV_INSTRUMENT := n
		UBSAN_SANITIZE := n

Admin message