Commit c16467dc authored by Trond Myklebust's avatar Trond Myklebust Committed by Anna Schumaker
Browse files

pnfs: Fix handling of NFS4ERR_OLD_STATEID replies to layoutreturn 



If the server tells us that out layoutreturn raced with another layout
update, then we must ensure that the new layout segments are not in use
before we resend with an updated layout stateid.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 8d4fb8ff

fs/nfs/nfs4proc.c

+3 −3
Original line number Diff line number Diff line
@@ -3232,7 +3232,7 @@ static void nfs4_close_done(struct rpc_task *task, void *data) 
			calldata->res.lr_res = NULL;

			break;

		case -NFS4ERR_OLD_STATEID:

			if (nfs4_refresh_layout_stateid(&calldata->arg.lr_args->stateid,

			if (nfs4_layoutreturn_refresh_stateid(&calldata->arg.lr_args->stateid,

						calldata->inode))

				goto lr_restart;

			/* Fallthrough */
@@ -5914,7 +5914,7 @@ static void nfs4_delegreturn_done(struct rpc_task *task, void *calldata) 
			data->res.lr_res = NULL;

			break;

		case -NFS4ERR_OLD_STATEID:

			if (nfs4_refresh_layout_stateid(&data->args.lr_args->stateid,

			if (nfs4_layoutreturn_refresh_stateid(&data->args.lr_args->stateid,

						data->inode))

				goto lr_restart;

			/* Fallthrough */
@@ -8863,7 +8863,7 @@ static void nfs4_layoutreturn_done(struct rpc_task *task, void *calldata) 
	server = NFS_SERVER(lrp->args.inode);

	switch (task->tk_status) {

	case -NFS4ERR_OLD_STATEID:

		if (nfs4_refresh_layout_stateid(&lrp->args.stateid,

		if (nfs4_layoutreturn_refresh_stateid(&lrp->args.stateid,

					lrp->args.inode))

			goto out_restart;

		/* Fallthrough */

fs/nfs/pnfs.c

+14 −3
Original line number Diff line number Diff line
@@ -361,18 +361,29 @@ pnfs_clear_lseg_state(struct pnfs_layout_segment *lseg, 
/*

 * Update the seqid of a layout stateid

 */

bool nfs4_refresh_layout_stateid(nfs4_stateid *dst, struct inode *inode)

bool nfs4_layoutreturn_refresh_stateid(nfs4_stateid *dst, struct inode *inode)

{

	struct pnfs_layout_hdr *lo;

	struct pnfs_layout_range range = {

		.iomode = IOMODE_ANY,

		.offset = 0,

		.length = NFS4_MAX_UINT64,

	};

	bool ret = false;

	LIST_HEAD(head);

	int err;



	spin_lock(&inode->i_lock);

	lo = NFS_I(inode)->layout;

	if (lo && nfs4_stateid_match_other(dst, &lo->plh_stateid)) {

		err = pnfs_mark_matching_lsegs_return(lo, &head, &range, 0);

		if (err != -EBUSY) {

			dst->seqid = lo->plh_stateid.seqid;

			ret = true;

		}

	}

	spin_unlock(&inode->i_lock);

	pnfs_free_lseg_list(&head);

	return ret;

}

fs/nfs/pnfs.h

+2 −2
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ int pnfs_destroy_layouts_byfsid(struct nfs_client *clp, 
		bool is_recall);

int pnfs_destroy_layouts_byclid(struct nfs_client *clp,

		bool is_recall);

bool nfs4_refresh_layout_stateid(nfs4_stateid *dst, struct inode *inode);

bool nfs4_layoutreturn_refresh_stateid(nfs4_stateid *dst, struct inode *inode);

void pnfs_put_layout_hdr(struct pnfs_layout_hdr *lo);

void pnfs_set_layout_stateid(struct pnfs_layout_hdr *lo,

			     const nfs4_stateid *new,
@@ -780,7 +780,7 @@ static inline void nfs4_pnfs_v3_ds_connect_unload(void) 
{

}



static inline bool nfs4_refresh_layout_stateid(nfs4_stateid *dst,

static inline bool nfs4_layoutreturn_refresh_stateid(nfs4_stateid *dst,

		struct inode *inode)

{

	return false;

CRA Git | Maintained and supported by SUSTech CRA and CCSE