Commit c142932c authored Apr 12, 2020 by Darrick J. Wong

xfs: fix partially uninitialized structure in xfs_reflink_remap_extent



In the reflink extent remap function, it turns out that uirec (the block
mapping corresponding only to the part of the passed-in mapping that got
unmapped) was not fully initialized.  Specifically, br_state was not
being copied from the passed-in struct to the uirec.  This could lead to
unpredictable results such as the reflinked mapping being marked
unwritten in the destination file.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>

parent 4b674b9a

fs/xfs/xfs_reflink.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1051,6 +1051,7 @@ xfs_reflink_remap_extent(
		uirec.br_startblock = irec->br_startblock + rlen;
		uirec.br_startoff = irec->br_startoff + rlen;
		uirec.br_blockcount = unmap_len - rlen;
		uirec.br_state = irec->br_state;
		unmap_len = rlen;

		/* If this isn't a real mapping, we're done. */

Admin message