Commit c13f99b7 authored Sep 16, 2015 by Suman Anna Committed by Michael S. Tsirkin Dec 07, 2015

virtio: fix memory leak of virtio ida cache layers



The virtio core uses a static ida named virtio_index_ida for
assigning index numbers to virtio devices during registration.
The ida core may allocate some internal idr cache layers and
an ida bitmap upon any ida allocation, and all these layers are
truely freed only upon the ida destruction. The virtio_index_ida
is not destroyed at present, leading to a memory leak when using
the virtio core as a module and atleast one virtio device is
registered and unregistered.

Fix this by invoking ida_destroy() in the virtio core module
exit.

Cc: stable@vger.kernel.org
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent d5424838

drivers/virtio/virtio.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -412,6 +412,7 @@ static int virtio_init(void)
		static void __exit virtio_exit(void)
		{
		bus_unregister(&virtio_bus);
		ida_destroy(&virtio_index_ida);
		}
		core_initcall(virtio_init);
		module_exit(virtio_exit);

Admin message