Commit c13e1c05 authored Oct 08, 2015 by Colin Ian King Committed by Michael Ellerman Oct 09, 2015

powerpc/pseries/hvcserver: don't memset pi_buff if it is null



pi_buff is being memset before it is sanity checked. Move the
memset after the null pi_buff sanity check to avoid an oops.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent f78f7ed7

arch/powerpc/platforms/pseries/hvcserver.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -142,11 +142,11 @@ int hvcs_get_partner_info(uint32_t unit_address, struct list_head *head,
		int more = 1;
		int retval;

		memset(pi_buff, 0x00, PAGE_SIZE);
		/* invalid parameters */
		if (!head \|\| !pi_buff)
		return -EINVAL;

		memset(pi_buff, 0x00, PAGE_SIZE);
		last_p_partition_ID = last_p_unit_address = ~0UL;
		INIT_LIST_HEAD(head);

Admin message