Commit c138325f authored Nov 13, 2018 by Ondrej Mosnacek Committed by Paul Moore Nov 13, 2018

selinux: check length properly in SCTP bind hook



selinux_sctp_bind_connect() must verify if the address buffer has
sufficient length before accessing the 'sa_family' field. See
__sctp_connect() for a similar check.

The length of the whole address ('len') is already checked in the
callees.

Reported-by: Qian Cai <cai@gmx.us>
Fixes: d452930f ("selinux: Add SCTP support")
Cc: <stable@vger.kernel.org> # 4.17+
Cc: Richard Haines <richard_c_haines@btinternet.com>
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Tested-by: Qian Cai <cai@gmx.us>
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent 4458bba0

security/selinux/hooks.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -5318,6 +5318,9 @@ static int selinux_sctp_bind_connect(struct sock *sk, int optname,
		addr_buf = address;

		while (walk_size < addrlen) {
		if (walk_size + sizeof(sa_family_t) > addrlen)
		return -EINVAL;

		addr = addr_buf;
		switch (addr->sa_family) {
		case AF_UNSPEC:

Admin message