Commit c1309fd0 authored Jul 14, 2020 by Lee Jones Committed by Vinod Koul Jul 15, 2020

dmaengine: ioat: Fix some parameter misspelling and provide description for phys_complete

Fixes the following W=1 kernel build warning(s):

drivers/dma/ioat/dma.c:202: warning: Function parameter or member 'ioat_chan' not described in 'ioat_update_pending'
drivers/dma/ioat/dma.c:202: warning: Excess function parameter 'ioat' description in 'ioat_update_pending'
drivers/dma/ioat/dma.c:465: warning: Function parameter or member 'ioat_chan' not described in 'ioat_check_space_lock'
drivers/dma/ioat/dma.c:465: warning: Excess function parameter 'ioat' description in 'ioat_check_space_lock'
drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'ioat_chan' not described in '__cleanup'
drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'phys_complete' not described in '__cleanup'
drivers/dma/ioat/dma.c:591: warning: Excess function parameter 'ioat' description in '__cleanup'

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Leonid Ravich <Leonid.Ravich@emc.com>
Link: https://lore.kernel.org/r/20200714111546.1755231-18-lee.jones@linaro.org

Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent af49b016

drivers/dma/ioat/dma.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -181,7 +181,7 @@ void ioat_issue_pending(struct dma_chan *c)

		/**
		* ioat_update_pending - log pending descriptors
		* @ioat: ioat+ channel
		* @ioat_chan: ioat+ channel
		*
		* Check if the number of unsubmitted descriptors has exceeded the
		* watermark. Called with prep_lock held
		@@ -445,7 +445,7 @@ ioat_alloc_ring(struct dma_chan *c, int order, gfp_t flags)

		/**
		* ioat_check_space_lock - verify space and grab ring producer lock
		* @ioat: ioat,3 channel (ring) to operate on
		* @ioat_chan: ioat,3 channel (ring) to operate on
		* @num_descs: allocation length
		*/
		int ioat_check_space_lock(struct ioatdma_chan *ioat_chan, int num_descs)
		@@ -573,7 +573,8 @@ desc_get_errstat(struct ioatdma_chan ioat_chan, struct ioat_ring_ent desc)

		/**
		* __cleanup - reclaim used descriptors
		* @ioat: channel (ring) to clean
		* @ioat_chan: channel (ring) to clean
		* @phys_complete: zeroed (or not) completion address (from status)
		*/
		static void __cleanup(struct ioatdma_chan *ioat_chan, dma_addr_t phys_complete)
		{

Admin message