Commit c11a6cfb authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'for-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq 

Pull workqueue updates from Tejun Heo:
 "Mostly patches to initialize workqueue subsystem earlier and get rid
  of keventd_up().

  The patches were headed for the last merge cycle but got delayed due
  to a bug found late minute, which is fixed now.

  Also, to help debugging, destroy_workqueue() is more chatty now on a
  sanity check failure."

* 'for-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq:
  workqueue: move wq_numa_init() to workqueue_init()
  workqueue: remove keventd_up()
  debugobj, workqueue: remove keventd_up() usage
  slab, workqueue: remove keventd_up() usage
  power, workqueue: remove keventd_up() usage
  tty, workqueue: remove keventd_up() usage
  mce, workqueue: remove keventd_up() usage
  workqueue: make workqueue available early during boot
  workqueue: dump workqueue state on sanity check failures in destroy_workqueue()
parents e6efef72 8bc4a044

arch/x86/kernel/cpu/mcheck/mce.c

+1 −1
Original line number Diff line number Diff line
@@ -516,7 +516,7 @@ int mce_available(struct cpuinfo_x86 *c) 


static void mce_schedule_work(void)

{

	if (!mce_gen_pool_empty() && keventd_up())

	if (!mce_gen_pool_empty())

		schedule_work(&mce_work);

}

drivers/tty/vt/vt.c

+0 −4
Original line number Diff line number Diff line
@@ -3923,10 +3923,6 @@ void unblank_screen(void) 
 */

static void blank_screen_t(unsigned long dummy)

{

	if (unlikely(!keventd_up())) {

		mod_timer(&console_timer, jiffies + (blankinterval * HZ));

		return;

	}

	blank_timer_expired = 1;

	schedule_work(&console_work);

}

include/linux/workqueue.h

+3 −8
Original line number Diff line number Diff line
@@ -603,14 +603,6 @@ static inline bool schedule_delayed_work(struct delayed_work *dwork, 
	return queue_delayed_work(system_wq, dwork, delay);

}



/**

 * keventd_up - is workqueue initialized yet?

 */

static inline bool keventd_up(void)

{

	return system_wq != NULL;

}



#ifndef CONFIG_SMP

static inline long work_on_cpu(int cpu, long (*fn)(void *), void *arg)

{
@@ -645,4 +637,7 @@ int workqueue_online_cpu(unsigned int cpu); 
int workqueue_offline_cpu(unsigned int cpu);

#endif



int __init workqueue_init_early(void);

int __init workqueue_init(void);



#endif

init/main.c

+10 −0
Original line number Diff line number Diff line
@@ -553,6 +553,14 @@ asmlinkage __visible void __init start_kernel(void) 
		 "Interrupts were enabled *very* early, fixing it\n"))

		local_irq_disable();

	idr_init_cache();



	/*

	 * Allow workqueue creation and work item queueing/cancelling

	 * early.  Work item execution depends on kthreads and starts after

	 * workqueue_init().

	 */

	workqueue_init_early();



	rcu_init();



	/* trace_printk() and trace points may be used after this */
@@ -1009,6 +1017,8 @@ static noinline void __init kernel_init_freeable(void) 


	smp_prepare_cpus(setup_max_cpus);



	workqueue_init();



	do_pre_smp_initcalls();

	lockup_detector_init();

kernel/power/qos.c

+1 −10
Original line number Diff line number Diff line
@@ -482,16 +482,7 @@ void pm_qos_update_request(struct pm_qos_request *req, 
		return;

	}



	/*

	 * This function may be called very early during boot, for example,

	 * from of_clk_init(), where irq needs to stay disabled.

	 * cancel_delayed_work_sync() assumes that irq is enabled on

	 * invocation and re-enables it on return.  Avoid calling it until

	 * workqueue is initialized.

	 */

	if (keventd_up())

	cancel_delayed_work_sync(&req->work);



	__pm_qos_update_request(req, new_value);

}

EXPORT_SYMBOL_GPL(pm_qos_update_request);

CRA Git | Maintained and supported by SUSTech CRA and CCSE