Commit c110a4b6 authored Aug 30, 2017 by NeilBrown Committed by Mike Snitzer Dec 13, 2017

dm io: remove BIOSET_NEED_RESCUER flag from bios bioset



The BIOSET_NEED_RESCUER flag is only needed when a make_request_fn might
do two allocations from the one bioset, and the second one could block
until the first bio completes.

dm_io() is called from make_request_fn() context.  The closest it comes
to multiple allocations is in chunk_io() in dm-snap-persistent.  But
there the code uses a separate thread to avoid problems.

So BIOSET_NEED_RESCUER is not needed.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent 80cd1757

drivers/md/dm-io.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -58,8 +58,7 @@ struct dm_io_client *dm_io_client_create(void)
	if (!client->pool)		if (!client->pool)
	goto bad;		goto bad;

	client->bios = bioset_create(min_ios, 0, (BIOSET_NEED_BVECS \|		client->bios = bioset_create(min_ios, 0, BIOSET_NEED_BVECS);
	BIOSET_NEED_RESCUER));
	if (!client->bios)		if (!client->bios)
	goto bad;		goto bad;

Admin message