Commit c0ff7e2c authored Sep 20, 2017 by Meng Xu Committed by Martin K. Petersen Sep 25, 2017

scsi: mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo



Since right after the user copy, we are going to memset(&karg, 0,
sizeof(karg)), the copy_from_user is redundant

Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 08eb7f45

drivers/scsi/mpt3sas/mpt3sas_ctl.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1065,12 +1065,6 @@ _ctl_getiocinfo(struct MPT3SAS_ADAPTER ioc, void __user arg)
		{
		struct mpt3_ioctl_iocinfo karg;

		if (copy_from_user(&karg, arg, sizeof(karg))) {
		pr_err("failure at %s:%d/%s()!\n",
		__FILE__, __LINE__, __func__);
		return -EFAULT;
		}

		dctlprintk(ioc, pr_info(MPT3SAS_FMT "%s: enter\n", ioc->name,
		__func__));

Admin message