Commit c0e4aa78 authored by Mario Limonciello's avatar Mario Limonciello Committed by Darren Hart (VMware)
Browse files

platform/x86: alienware-wmi: Adjust instance of wmi_evaluate_method calls to 0 



Pali recently noticed that WMI instances are zero indexed.

The only reason that these calls all worked properly is because the ASL
didn't verify the instance number.

Signed-off-by: default avatarMario Limonciello <mario.limonciello@dell.com>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 20485a56

drivers/platform/x86/alienware-wmi.c

+4 −4
Original line number Diff line number Diff line
@@ -303,7 +303,7 @@ static int alienware_update_led(struct platform_zone *zone) 
	}

	pr_debug("alienware-wmi: guid %s method %d\n", guid, method_id);



	status = wmi_evaluate_method(guid, 1, method_id, &input, NULL);

	status = wmi_evaluate_method(guid, 0, method_id, &input, NULL);

	if (ACPI_FAILURE(status))

		pr_err("alienware-wmi: zone set failure: %u\n", status);

	return ACPI_FAILURE(status);
@@ -352,7 +352,7 @@ static int wmax_brightness(int brightness) 
	};

	input.length = (acpi_size) sizeof(args);

	input.pointer = &args;

	status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1,

	status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0,

				     WMAX_METHOD_BRIGHTNESS, &input, NULL);

	if (ACPI_FAILURE(status))

		pr_err("alienware-wmi: brightness set failure: %u\n", status);
@@ -506,10 +506,10 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args, 
	if (out_data != NULL) {

		output.length = ACPI_ALLOCATE_BUFFER;

		output.pointer = NULL;

		status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1,

		status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0,

					     command, &input, &output);

	} else

		status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1,

		status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0,

					     command, &input, NULL);



	if (ACPI_SUCCESS(status) && out_data != NULL) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE