rtc: s35390a: set uie_unsupported (c0e12848) · Commits · 戴 / test

Alarms are only supported on a per minute basis. This is why uie_unsupported is set. Furthermore issue a warning when a second based alarm is requested. Signed-off-by:

Richard Leitner <richard.leitner@skidata.com> Signed-off-by:

Alexandre Belloni <alexandre.belloni@bootlin.com>

drivers/rtc/rtc-s35390a.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -289,6 +289,9 @@ static int s35390a_rtc_set_alarm(struct device dev, struct rtc_wkalrm alm)
		alm->time.tm_min, alm->time.tm_hour, alm->time.tm_mday,
		alm->time.tm_mon, alm->time.tm_year, alm->time.tm_wday);

		if (alm->time.tm_sec != 0)
		dev_warn(&client->dev, "Alarms are only supported on a per minute basis!\n");

		/* disable interrupt (which deasserts the irq line) */
		err = s35390a_set_reg(s35390a, S35390A_CMD_STATUS2, &sts, sizeof(sts));
		if (err < 0)
		@@ -500,6 +503,9 @@ static int s35390a_probe(struct i2c_client *client,
		goto exit_dummy;
		}

		/* supports per-minute alarms only, therefore set uie_unsupported */
		s35390a->rtc->uie_unsupported = 1;

		if (status1 & S35390A_FLAG_INT2)
		rtc_update_irq(s35390a->rtc, 1, RTC_AF);

Admin message