Commit c0c7babc authored by Ben Widawsky's avatar Ben Widawsky Committed by Daniel Vetter
Browse files

drm/i915: add register read IOCTL 



The interface's immediate purpose is to do synchronous timestamp queries
as required by GL_TIMESTAMP. The GPU has a register for reading the
timestamp but because that would normally require root access through
libpciaccess, the IOCTL can provide this service instead.

Currently the implementation whitelists only the render ring timestamp
register, because that is the only thing we need to expose at this time.

v2: make size implicit based on the register offset
Add a generation check

Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Cc: Jacek Lawrynowicz <jacek.lawrynowicz@intel.com>
Signed-off-by: default avatarBen Widawsky <ben@bwidawsk.net>
[danvet: fixup the ioctl numerb:]
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 2b860db6

drivers/gpu/drm/i915/i915_dma.c

+1 −0
Original line number Diff line number Diff line
@@ -1857,6 +1857,7 @@ struct drm_ioctl_desc i915_ioctls[] = { 
	DRM_IOCTL_DEF_DRV(I915_GEM_WAIT, i915_gem_wait_ioctl, DRM_AUTH|DRM_UNLOCKED),

	DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE, i915_gem_context_create_ioctl, DRM_UNLOCKED),

	DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_DESTROY, i915_gem_context_destroy_ioctl, DRM_UNLOCKED),

	DRM_IOCTL_DEF_DRV(I915_REG_READ, i915_reg_read_ioctl, DRM_UNLOCKED),

};



int i915_max_ioctl = DRM_ARRAY_SIZE(i915_ioctls);

drivers/gpu/drm/i915/i915_drv.c

+46 −0
Original line number Diff line number Diff line
@@ -1151,3 +1151,49 @@ __i915_write(16, w) 
__i915_write(32, l)

__i915_write(64, q)

#undef __i915_write



static const struct register_whitelist {

	uint64_t offset;

	uint32_t size;

	uint32_t gen_bitmask; /* support gens, 0x10 for 4, 0x30 for 4 and 5, etc. */

} whitelist[] = {

	{ RING_TIMESTAMP(RENDER_RING_BASE), 8, 0xF0 },

};



int i915_reg_read_ioctl(struct drm_device *dev,

			void *data, struct drm_file *file)

{

	struct drm_i915_private *dev_priv = dev->dev_private;

	struct drm_i915_reg_read *reg = data;

	struct register_whitelist const *entry = whitelist;

	int i;



	for (i = 0; i < ARRAY_SIZE(whitelist); i++, entry++) {

		if (entry->offset == reg->offset &&

		    (1 << INTEL_INFO(dev)->gen & entry->gen_bitmask))

			break;

	}



	if (i == ARRAY_SIZE(whitelist))

		return -EINVAL;



	switch (entry->size) {

	case 8:

		reg->val = I915_READ64(reg->offset);

		break;

	case 4:

		reg->val = I915_READ(reg->offset);

		break;

	case 2:

		reg->val = I915_READ16(reg->offset);

		break;

	case 1:

		reg->val = I915_READ8(reg->offset);

		break;

	default:

		WARN_ON(1);

		return -EINVAL;

	}



	return 0;

}

drivers/gpu/drm/i915/i915_drv.h

+2 −0
Original line number Diff line number Diff line
@@ -1529,6 +1529,8 @@ extern int intel_trans_dp_port_sel(struct drm_crtc *crtc); 
extern int intel_enable_rc6(const struct drm_device *dev);



extern bool i915_semaphore_is_enabled(struct drm_device *dev);

int i915_reg_read_ioctl(struct drm_device *dev, void *data,

			struct drm_file *file);



/* overlay */

#ifdef CONFIG_DEBUG_FS

drivers/gpu/drm/i915/i915_reg.h

+1 −0
Original line number Diff line number Diff line
@@ -449,6 +449,7 @@ 
#define RING_ACTHD(base)	((base)+0x74)

#define RING_NOPID(base)	((base)+0x94)

#define RING_IMR(base)		((base)+0xa8)

#define RING_TIMESTAMP(base)	((base)+0x358)

#define   TAIL_ADDR		0x001FFFF8

#define   HEAD_WRAP_COUNT	0xFFE00000

#define   HEAD_WRAP_ONE		0x00200000

include/drm/i915_drm.h

+7 −1
Original line number Diff line number Diff line
@@ -205,6 +205,7 @@ typedef struct _drm_i915_sarea { 
#define DRM_I915_GEM_CONTEXT_DESTROY	0x2e

#define DRM_I915_GEM_SET_CACHEING	0x2f

#define DRM_I915_GEM_GET_CACHEING	0x30

#define DRM_I915_REG_READ		0x31



#define DRM_IOCTL_I915_INIT		DRM_IOW( DRM_COMMAND_BASE + DRM_I915_INIT, drm_i915_init_t)

#define DRM_IOCTL_I915_FLUSH		DRM_IO ( DRM_COMMAND_BASE + DRM_I915_FLUSH)
@@ -253,6 +254,7 @@ typedef struct _drm_i915_sarea { 
#define DRM_IOCTL_I915_GEM_WAIT		DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_WAIT, struct drm_i915_gem_wait)

#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE	DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create)

#define DRM_IOCTL_I915_GEM_CONTEXT_DESTROY	DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_DESTROY, struct drm_i915_gem_context_destroy)

#define DRM_IOCTL_I915_REG_READ			DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_REG_READ, struct drm_i915_reg_read)



/* Allow drivers to submit batchbuffers directly to hardware, relying

 * on the security mechanisms provided by hardware.
@@ -710,7 +712,7 @@ struct drm_i915_gem_busy { 
#define I915_CACHEING_CACHED		1



struct drm_i915_gem_cacheing {

	/** Handle of the buffer to check for busy */

	/** Handle of the buffer to set/get the cacheing level of */

	__u32 handle;



	/** Cacheing level to apply or return value */
@@ -933,4 +935,8 @@ struct drm_i915_gem_context_destroy { 
	__u32 pad;

};



struct drm_i915_reg_read {

	__u64 offset;

	__u64 val; /* Return value */

};

#endif				/* _I915_DRM_H_ */

CRA Git | Maintained and supported by SUSTech CRA and CCSE