Commit c09f1218 authored Aug 19, 2016 by Vishal Verma Committed by Dan Williams Aug 23, 2016

acpi, nfit: check for the correct event code in notifications



Commit 20985164 "acpi: nfit: Add support for hot-add" added
support for _FIT notifications, but it neglected to verify the
notification event code matches the one in the ACPI spec for
"NFIT Update". Currently there is only one code in the spec, but
once additional codes are added, older kernels (without this fix)
will misbehave by assuming all event notifications are for an
NFIT Update.

Fixes: 20985164 ("acpi: nfit: Add support for hot-add")
Cc: <stable@vger.kernel.org>
Cc: <linux-acpi@vger.kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Reported-by: Linda Knippers <linda.knippers@hpe.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 02486c29

drivers/acpi/nfit/core.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2681,6 +2681,9 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event)

		dev_dbg(dev, "%s: event: %d\n", __func__, event);

		if (event != NFIT_NOTIFY_UPDATE)
		return;

		device_lock(dev);
		if (!dev->driver) {
		/* dev->driver may be null if we're being removed */

drivers/acpi/nfit/nfit.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -78,6 +78,10 @@ enum {
		NFIT_ARS_TIMEOUT = 90,
		};

		enum nfit_root_notifiers {
		NFIT_NOTIFY_UPDATE = 0x80,
		};

		struct nfit_spa {
		struct list_head list;
		struct nd_region *nd_region;

Admin message