Commit c095adbc authored Dec 16, 2008 by KOSAKI Motohiro Committed by Linus Torvalds Dec 16, 2008

mm: Don't touch uninitialized variable in do_pages_stat_array()



Commit 80bba129 removed one necessary
variable initialization.  As a result following warning happened:

    CC      mm/migrate.o
  mm/migrate.c: In function 'sys_move_pages':
  mm/migrate.c:1001: warning: 'err' may be used uninitialized in this function

More unfortunately, if find_vma() failed, kernel read uninitialized
memory.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Brice Goglin <Brice.Goglin@inria.fr>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a3dd1544

mm/migrate.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -998,7 +998,7 @@ static void do_pages_stat_array(struct mm_struct *mm, unsigned long nr_pages,
	unsigned long addr = (unsigned long)(*pages);		unsigned long addr = (unsigned long)(*pages);
	struct vm_area_struct *vma;		struct vm_area_struct *vma;
	struct page *page;		struct page *page;
	int err;		int err = -EFAULT;

	vma = find_vma(mm, addr);		vma = find_vma(mm, addr);
	if (!vma)		if (!vma)

Admin message