drm/gma500: Constify static structs (c08503ec) · Commits · 戴 / test

The only usage of these is to assign their address to the fbops field in the fb_info struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by:

Rikard Falkeborn <rikard.falkeborn@gmail.com> Signed-off-by:

Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20200830211741.17326-1-rikard.falkeborn@gmail.com

drivers/gpu/drm/gma500/framebuffer.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -164,7 +164,7 @@ static int psbfb_mmap(struct fb_info info, struct vm_area_struct vma)
		return 0;
		}

		static struct fb_ops psbfb_ops = {
		static const struct fb_ops psbfb_ops = {
		.owner = THIS_MODULE,
		DRM_FB_HELPER_DEFAULT_OPS,
		.fb_setcolreg = psbfb_setcolreg,
		@@ -175,7 +175,7 @@ static struct fb_ops psbfb_ops = {
		.fb_sync = psbfb_sync,
		};

		static struct fb_ops psbfb_roll_ops = {
		static const struct fb_ops psbfb_roll_ops = {
		.owner = THIS_MODULE,
		DRM_FB_HELPER_DEFAULT_OPS,
		.fb_setcolreg = psbfb_setcolreg,
		@@ -186,7 +186,7 @@ static struct fb_ops psbfb_roll_ops = {
		.fb_mmap = psbfb_mmap,
		};

		static struct fb_ops psbfb_unaccel_ops = {
		static const struct fb_ops psbfb_unaccel_ops = {
		.owner = THIS_MODULE,
		DRM_FB_HELPER_DEFAULT_OPS,
		.fb_setcolreg = psbfb_setcolreg,

Admin message