Commit c0735ae9 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Rich Felker
Browse files

sh: stacktrace: Remove stacktrace_ops.stack() 



The SH implementation never called stacktrace_ops.stack().
Presumably this was copied from the x86 implementation.

Hence remove the method, and all implementations (most of them are
dummies).

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarRich Felker <dalias@libc.org>
parent eac1a488

arch/sh/include/asm/stacktrace.h

+0 −2
Original line number Diff line number Diff line
@@ -12,8 +12,6 @@ 


struct stacktrace_ops {

	void (*address)(void *data, unsigned long address, int reliable);

	/* On negative return stop dumping */

	int (*stack)(void *data, char *name);

};



void dump_trace(struct task_struct *tsk, struct pt_regs *regs,

arch/sh/kernel/dumpstack.c

+0 −7
Original line number Diff line number Diff line
@@ -107,12 +107,6 @@ stack_reader_dump(struct task_struct *task, struct pt_regs *regs, 
	}

}



static int print_trace_stack(void *data, char *name)

{

	printk("%s <%s> ", (char *)data, name);

	return 0;

}



/*

 * Print one address/symbol entries per line.

 */
@@ -123,7 +117,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops print_trace_ops = {

	.stack = print_trace_stack,

	.address = print_trace_address,

};

arch/sh/kernel/perf_callchain.c

+0 −6
Original line number Diff line number Diff line
@@ -11,11 +11,6 @@ 
#include <asm/unwinder.h>

#include <asm/ptrace.h>



static int callchain_stack(void *data, char *name)

{

	return 0;

}



static void callchain_address(void *data, unsigned long addr, int reliable)

{

	struct perf_callchain_entry_ctx *entry = data;
@@ -25,7 +20,6 @@ static void callchain_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops callchain_ops = {

	.stack		= callchain_stack,

	.address	= callchain_address,

};

arch/sh/kernel/stacktrace.c

+0 −7
Original line number Diff line number Diff line
@@ -15,11 +15,6 @@ 
#include <asm/ptrace.h>

#include <asm/stacktrace.h>



static int save_stack_stack(void *data, char *name)

{

	return 0;

}



/*

 * Save stack-backtrace addresses into a stack_trace buffer.

 */
@@ -40,7 +35,6 @@ static void save_stack_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops save_stack_ops = {

	.stack = save_stack_stack,

	.address = save_stack_address,

};
@@ -73,7 +67,6 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops save_stack_ops_nosched = {

	.stack = save_stack_stack,

	.address = save_stack_address_nosched,

};

arch/sh/oprofile/backtrace.c

+0 −7
Original line number Diff line number Diff line
@@ -19,12 +19,6 @@ 
#include <asm/sections.h>

#include <asm/stacktrace.h>



static int backtrace_stack(void *data, char *name)

{

	/* Yes, we want all stacks */

	return 0;

}



static void backtrace_address(void *data, unsigned long addr, int reliable)

{

	unsigned int *depth = data;
@@ -34,7 +28,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable) 
}



static struct stacktrace_ops backtrace_ops = {

	.stack = backtrace_stack,

	.address = backtrace_address,

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE