Commit c06b6d70 authored Apr 15, 2016 by Stefano Stabellini Committed by David Vrabel May 24, 2016

xen/x86: don't lose event interrupts



On slow platforms with unreliable TSC, such as QEMU emulated machines,
it is possible for the kernel to request the next event in the past. In
that case, in the current implementation of xen_vcpuop_clockevent, we
simply return -ETIME. To be precise the Xen returns -ETIME and we pass
it on. However the result of this is a missed event, which simply causes
the kernel to hang.

Instead it is better to always ask the hypervisor for a timer event,
even if the timeout is in the past. That way there are no lost
interrupts and the kernel survives. To do that, remove the
VCPU_SSHOTTMR_future flag.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Juergen Gross <jgross@suse.com>

parent c3b46c73

arch/x86/xen/time.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -290,11 +290,11 @@ static int xen_vcpuop_set_next_event(unsigned long delta,
		WARN_ON(!clockevent_state_oneshot(evt));

		single.timeout_abs_ns = get_abs_timeout(delta);
		single.flags = VCPU_SSHOTTMR_future;
		/* Get an event anyway, even if the timeout is already expired */
		single.flags = 0;

		ret = HYPERVISOR_vcpu_op(VCPUOP_set_singleshot_timer, cpu, &single);

		BUG_ON(ret != 0 && ret != -ETIME);
		BUG_ON(ret != 0);

		return ret;
		}

Admin message