Commit c05c403b authored Dec 17, 2019 by Jérôme Pouiller Committed by Greg Kroah-Hartman Dec 18, 2019

staging: wfx: fix wrong error message

The driver checks that the number of retries made by the device is
coherent with the rate policy. However, this check make sense only if
the device has returned RETRY_EXCEEDED.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20191217161318.31402-11-Jerome.Pouiller@silabs.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 63244113

drivers/staging/wfx/data_tx.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -748,7 +748,9 @@ void wfx_tx_confirm_cb(struct wfx_vif wvif, struct hif_cnf_tx arg)
		rate = &tx_info->status.rates[i];
		if (rate->idx < 0)
		break;
		if (tx_count < rate->count && arg->status && arg->ack_failures)
		if (tx_count < rate->count &&
		arg->status == HIF_STATUS_RETRY_EXCEEDED &&
		arg->ack_failures)
		dev_dbg(wvif->wdev->dev, "all retries were not consumed: %d != %d\n",
		rate->count, tx_count);
		if (tx_count <= rate->count && tx_count &&