Commit c04a17d2 authored Nov 06, 2018 by Florian Fainelli Committed by David S. Miller Nov 06, 2018

net: dsa: bcm_sf2: Turn on PHY to allow successful registration

We are binding to the PHY using the SF2 slave MDIO bus that we create,
binding involves reading the PHY's MII_PHYSID1/2 which won't be possible
if the PHY is turned off. Temporarily turn it on/off for the bus probing
to succeeed. This fixes unbind/bind problems where the port connecting
to that PHY would be in error since it could not connect to it.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5882d526

drivers/net/dsa/bcm_sf2.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1095,12 +1095,16 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev)
		return ret;
		}

		bcm_sf2_gphy_enable_set(priv->dev->ds, true);

		ret = bcm_sf2_mdio_register(ds);
		if (ret) {
		pr_err("failed to register MDIO bus\n");
		return ret;
		}

		bcm_sf2_gphy_enable_set(priv->dev->ds, false);

		ret = bcm_sf2_cfp_rst(priv);
		if (ret) {
		pr_err("failed to reset CFP\n");

Admin message