Commit c047dc1d authored by Vadym Kochan's avatar Vadym Kochan Committed by David S. Miller
Browse files

net: ipa: fix u32_replace_bits by u32p_xxx version 



Looks like u32p_replace_bits() should be used instead of
u32_replace_bits() which does not modifies the value but returns the
modified version.

Fixes: 2b9feef2 ("soc: qcom: ipa: filter and routing tables")
Signed-off-by: default avatarVadym Kochan <vadym.kochan@plvision.eu>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a1b80e01

drivers/net/ipa/ipa_table.c

+2 −2
Original line number Diff line number Diff line
@@ -521,7 +521,7 @@ static void ipa_filter_tuple_zero(struct ipa_endpoint *endpoint) 
	val = ioread32(endpoint->ipa->reg_virt + offset);



	/* Zero all filter-related fields, preserving the rest */

	u32_replace_bits(val, 0, IPA_REG_ENDP_FILTER_HASH_MSK_ALL);

	u32p_replace_bits(&val, 0, IPA_REG_ENDP_FILTER_HASH_MSK_ALL);



	iowrite32(val, endpoint->ipa->reg_virt + offset);

}
@@ -573,7 +573,7 @@ static void ipa_route_tuple_zero(struct ipa *ipa, u32 route_id) 
	val = ioread32(ipa->reg_virt + offset);



	/* Zero all route-related fields, preserving the rest */

	u32_replace_bits(val, 0, IPA_REG_ENDP_ROUTER_HASH_MSK_ALL);

	u32p_replace_bits(&val, 0, IPA_REG_ENDP_ROUTER_HASH_MSK_ALL);



	iowrite32(val, ipa->reg_virt + offset);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE