Commit c044b62c authored Apr 29, 2019 by Shant KumarX Sonnad Committed by Herbert Xu May 23, 2019

crypto: qat - add check for negative offset in alg precompute function



The offset is calculated based on type of hash algorithum.
If the algorithum is invalid the offset can have negative value.
Hence added negative offset check and return -EFAULT.

Reviewed-by: Conor Mcloughlin <conor.mcloughlin@intel.com>
Tested-by: Sergey Portnoy <sergey.portnoy@intel.com>
Signed-off-by: Shant KumarX Sonnad <shant.kumarx.sonnad@intel.com>
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 93322498

drivers/crypto/qat/qat_common/qat_algs.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -222,6 +222,9 @@ static int qat_alg_do_precomputes(struct icp_qat_hw_auth_algo_blk *hash,
		return -EFAULT;

		offset = round_up(qat_get_inter_state_size(ctx->qat_hash_alg), 8);
		if (offset < 0)
		return -EFAULT;

		hash_state_out = (__be32 *)(hash->sha.state1 + offset);
		hash512_state_out = (__be64 *)hash_state_out;

Admin message