Commit c0316470 authored Mar 07, 2019 by Stanislaw Gruszka Committed by Kalle Valo Mar 19, 2019

mt7601u: check chip version on probe



Since some USB device IDs are duplicated between mt7601u and mt76x0u
devices, check chip version on probe and return error if not match
0x7601.

Don't think this is serious issue, probe most likely will fail at
some other point for wrong device, but we do not have to configure
it if we know is not mt7601u device.

Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 688cd8bd

drivers/net/wireless/mediatek/mt7601u/usb.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -303,6 +303,10 @@ static int mt7601u_probe(struct usb_interface *usb_intf,
		mac_rev = mt7601u_rr(dev, MT_MAC_CSR0);
		dev_info(dev->dev, "ASIC revision: %08x MAC revision: %08x\n",
		asic_rev, mac_rev);
		if ((asic_rev >> 16) != 0x7601) {
		ret = -ENODEV;
		goto err;
		}

		/* Note: vendor driver skips this check for MT7601U */
		if (!(mt7601u_rr(dev, MT_EFUSE_CTRL) & MT_EFUSE_CTRL_SEL))

Admin message