Commit bff23714 authored Jul 08, 2016 by Rafał Miłecki Committed by Jacek Anaszewski Jul 11, 2016

leds: leds-gpio: Set of_node for created LED devices



When working with Device Tree we iterate over children of "gpio-leds"
compatible node and create LED device for each of them. We take care of
all common DT properties (label, default trigger, state, etc.), however
some triggers may want to support more of them.

It could be useful for timer trigger to support setting delay on/off
values with Device Tree property. Or for transient trigger to support
e.g. duration property.

We obviously should handle such properties in triggers, not in generic
code. To let trigger drivers read properties from DT node we need to set
of_node to point the relevant node. This change allows using all kind of
of helpers in e.g. "activate" callbacks.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent a3eac76c

drivers/leds/leds-gpio.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -165,6 +165,7 @@ static struct gpio_leds_priv gpio_leds_create(struct platform_device pdev)
		return ERR_PTR(-ENOMEM);

		device_for_each_child_node(dev, child) {
		struct gpio_led_data *led_dat = &priv->leds[priv->num_leds];
		struct gpio_led led = {};
		const char *state = NULL;

		@@ -205,12 +206,12 @@ static struct gpio_leds_priv gpio_leds_create(struct platform_device pdev)
		if (fwnode_property_present(child, "panic-indicator"))
		led.panic_indicator = 1;

		ret = create_gpio_led(&led, &priv->leds[priv->num_leds],
		dev, NULL);
		ret = create_gpio_led(&led, led_dat, dev, NULL);
		if (ret < 0) {
		fwnode_handle_put(child);
		goto err;
		}
		led_dat->cdev.dev->of_node = np;
		priv->num_leds++;
		}

Admin message