Commit bfdb4d9f authored Jun 23, 2009 by Arun R Bharadwaj Committed by Ingo Molnar Jun 23, 2009

timers: Fix timer_migration interface which accepts any number as input



Poornima Nayek reported:

| Timer migration interface /proc/sys/kernel/timer_migration in
| 2.6.30-git9 accepts any numerical value as input.
|
| Steps to reproduce:
| 1. echo -6666666 > /proc/sys/kernel/timer_migration
| 2. cat /proc/sys/kernel/timer_migration
| -6666666
|
| 1. echo 44444444444444444444444444444444444444444444444444444444444 > /proc/sys/kernel/timer_migration
| 2. cat /proc/sys/kernel/timer_migration
| -1357789412
|
| Expected behavior: Should 'echo: write error: Invalid argument' while
| setting any value other then 0 & 1

Restrict valid values to 0 and 1.

Reported-by: Poornima Nayak <mpnayak@linux.vnet.ibm.com>
Tested-by: Poornima Nayak <mpnayak@linux.vnet.ibm.com>
Signed-off-by: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
Cc: poornima nayak <mpnayak@linux.vnet.ibm.com>
Cc: Arun Bharadwaj <arun@linux.vnet.ibm.com>
LKML-Reference: <20090623043058.GA3249@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent d888a4c7

kernel/sysctl.c

+4 −1

Original line number	Original line	Diff line number	Diff line
	@@ -335,7 +335,10 @@ static struct ctl_table kern_table[] = {
	.data = &sysctl_timer_migration,		.data = &sysctl_timer_migration,
	.maxlen = sizeof(unsigned int),		.maxlen = sizeof(unsigned int),
	.mode = 0644,		.mode = 0644,
	.proc_handler = &proc_dointvec,		.proc_handler = &proc_dointvec_minmax,
			.strategy = &sysctl_intvec,
			.extra1 = &zero,
			.extra2 = &one,
	},		},
	#endif		#endif
	{		{

Admin message