Commit bf940776 authored Oct 07, 2016 by Bhaktipriya Shridhar Committed by Linus Torvalds Oct 07, 2016

fs/ocfs2/cluster: remove deprecated create_singlethread_workqueue()

The workqueue "o2net_wq" queues multiple work items viz
&old_sc->sc_shutdown_work, &sc->sc_rx_work, &sc->sc_connect_work which
require strict execution ordering.  Hence, an ordered dedicated
workqueue has been used.

WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.

Link: http://lkml.kernel.org/r/ddc12e5766c79ba26f8a00d98049107f8a1d4866.1472590094.git.bhaktipriya96@gmail.com


Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Joseph Qi <joseph.qi@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0b41be07

fs/ocfs2/cluster/tcp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2104,7 +2104,7 @@ int o2net_start_listening(struct o2nm_node *node)
		BUG_ON(o2net_listen_sock != NULL);

		mlog(ML_KTHREAD, "starting o2net thread...\n");
		o2net_wq = create_singlethread_workqueue("o2net");
		o2net_wq = alloc_ordered_workqueue("o2net", WQ_MEM_RECLAIM);
		if (o2net_wq == NULL) {
		mlog(ML_ERROR, "unable to launch o2net thread\n");
		return -ENOMEM; /* ? */

Admin message