Commit bf912d99 authored Aug 04, 2011 by Jamie Iles Committed by Russell King Aug 09, 2011

ARM: 7010/1: mm: fix invalid loop for poison_init_mem



poison_init_mem() used a loop of:

	while ((count = count - 4))

which has 2 problems - an off by one error so that we do one less word
than we should, and the other is that if count == 0 then we loop forever
and poison too much.  On a platform with HAVE_TCM=y but nothing in the
TCM's, this caused corruption and the platform failed to boot.

Acked-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 7760d546

arch/arm/mm/init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -441,7 +441,7 @@ static inline int free_area(unsigned long pfn, unsigned long end, char *s)
		static inline void poison_init_mem(void *s, size_t count)
		{
		u32 p = (u32 )s;
		while ((count = count - 4))
		for (; count != 0; count -= 4)
		*p++ = 0xe7fddef0;
		}

Admin message