Commit bf87ce5a authored Apr 05, 2007 by Alan Stern Committed by Greg Kroah-Hartman May 22, 2007

USB: remove unneeded WARN_ON



This patch (as883) removes an out-of-date WARN_ON from the main HCD
endpoint-disable routine.  The warning is triggered whenever an
endpoint is disabled while the root hub is suspended.  In the past
that may not have been legal, but it definitely is legal now.  Merely
unbinding a USB driver will do it.

Furthermore, I've never seen any occurrences of this warning that
really did signal an actual bug or error condition.  At this point it
has outlived its purpose.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

parent ef7f6c70

drivers/usb/core/hcd.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1175,10 +1175,6 @@ void usb_hcd_endpoint_disable (struct usb_device *udev,
		struct urb *urb;

		hcd = bus_to_hcd(udev->bus);

		WARN_ON (!HC_IS_RUNNING (hcd->state) && hcd->state != HC_STATE_HALT &&
		udev->state != USB_STATE_NOTATTACHED);

		local_irq_disable ();

		/* ep is already gone from udev->ep_{in,out}[]; no more submits */

Admin message