Commit bf7f547e authored Oct 03, 2018 by Colin Ian King Committed by Greg Kroah-Hartman Oct 09, 2018

usb: core: fix memory leak on port_dev_path allocation



Currently the allocation of port_dev_path from the call to
kobject_get_path is not being kfree'd, causing a memory leak. Fix
this by kfree'ing this at the end of the function. Add an extra
error exit path to fix one of the early leaks when envp[0] fails
to be allocated.

Detected by CoverityScan, CID#1473771 ("Resource Leak")

Fixes: 201af55d ("usb: core: added uevent for over-current")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6503016e

drivers/usb/core/hub.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -5170,7 +5170,7 @@ static void port_over_current_notify(struct usb_port *port_dev)

		envp[0] = kasprintf(GFP_KERNEL, "OVER_CURRENT_PORT=%s", port_dev_path);
		if (!envp[0])
		return;
		goto exit_path;

		envp[1] = kasprintf(GFP_KERNEL, "OVER_CURRENT_COUNT=%u",
		port_dev->over_current_count);
		@@ -5182,6 +5182,8 @@ static void port_over_current_notify(struct usb_port *port_dev)
		kfree(envp[1]);
		exit:
		kfree(envp[0]);
		exit_path:
		kfree(port_dev_path);
		}

		static void port_event(struct usb_hub *hub, int port1)

Admin message