Commit bf73c62e authored Mar 05, 2020 by Yan, Zheng Committed by Ilya Dryomov Mar 30, 2020

ceph: check all mds' caps after page writeback



If an inode has caps from multiple mds's, the following can happen:

- non-auth mds revokes Fsc. Fcb is used, so page writeback is queued.
- when writeback finishes, ceph_check_caps() is called with auth only
  flag. ceph_check_caps() invalidates pagecache, but skips checking any
  non-auth caps.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 11ba6b9c

fs/ceph/caps.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3062,7 +3062,7 @@ void ceph_put_wrbuffer_cap_refs(struct ceph_inode_info *ci, int nr,
		spin_unlock(&ci->i_ceph_lock);

		if (last) {
		ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL);
		ceph_check_caps(ci, 0, NULL);
		} else if (flush_snaps) {
		ceph_flush_snaps(ci, NULL);
		}

fs/ceph/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1984,7 +1984,7 @@ retry:
		mutex_unlock(&ci->i_truncate_mutex);

		if (wrbuffer_refs == 0)
		ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL);
		ceph_check_caps(ci, 0, NULL);

		wake_up_all(&ci->i_cap_wq);
		}

Admin message