Commit bf512b2d authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] stv0367: signedness bug in stv0367_get_tuner_freq() 



We use err to store negative error codes so it should be signed.  And
if we return an error from stv0367_get_tuner_freq() that needs to be
handled properly as well.  (param->frequency is a u32).

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent c6384c88

drivers/media/dvb/frontends/stv0367.c

+2 −2
Original line number Diff line number Diff line
@@ -913,7 +913,7 @@ static u32 stv0367_get_tuner_freq(struct dvb_frontend *fe) 
	struct dvb_frontend_ops	*frontend_ops = NULL;

	struct dvb_tuner_ops	*tuner_ops = NULL;

	u32 freq = 0;

	u32 err = 0;

	int err = 0;



	dprintk("%s:\n", __func__);
@@ -1940,7 +1940,7 @@ static int stv0367ter_get_frontend(struct dvb_frontend *fe, 
	int constell = 0,/* snr = 0,*/ Data = 0;



	param->frequency = stv0367_get_tuner_freq(fe);

	if (param->frequency < 0)

	if ((int)param->frequency < 0)

		param->frequency = c->frequency;



	constell = stv0367_readbits(state, F367TER_TPS_CONST);

CRA Git | Maintained and supported by SUSTech CRA and CCSE