Commit bf3fcf89 authored May 25, 2006 by Chuck Lever Committed by Trond Myklebust Jun 09, 2006

SUNRPC: NFS_ROOT always uses the same XIDs



The XID generator uses get_random_bytes to generate an initial XID.
NFS_ROOT starts up before the random driver, though, so get_random_bytes
doesn't set a random XID for NFS_ROOT.  This causes NFS_ROOT mount points
to reuse XIDs every time the client is booted.  If the client boots often
enough, the server will start serving old replies out of its DRC.

Use net_random() instead.

Test plan:
I/O intensive workloads should perform well and generate no errors.  Traces
taken during client reboots should show that NFS_ROOT mounts use unique
XIDs after every reboot.

Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent b85d8806

net/sunrpc/xprt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -41,7 +41,7 @@
		#include <linux/types.h>
		#include <linux/interrupt.h>
		#include <linux/workqueue.h>
		#include <linux/random.h>
		#include <linux/net.h>

		#include <linux/sunrpc/clnt.h>
		#include <linux/sunrpc/metrics.h>
		@@ -830,7 +830,7 @@ static inline u32 xprt_alloc_xid(struct rpc_xprt *xprt)

		static inline void xprt_init_xid(struct rpc_xprt *xprt)
		{
		get_random_bytes(&xprt->xid, sizeof(xprt->xid));
		xprt->xid = net_random();
		}

		static void xprt_request_init(struct rpc_task task, struct rpc_xprt xprt)

Admin message