Commit bf3e2692 authored Oct 09, 2014 by Baoquan He Committed by Linus Torvalds Oct 09, 2014

fs/proc/kcore.c: don't add modules range to kcore if it's equal to vmcore range



On some ARCHs modules range is eauql to vmalloc range. E.g on i686

	"#define MODULES_VADDR   VMALLOC_START"
	"#define MODULES_END     VMALLOC_END"

This will cause 2 duplicate program segments in /proc/kcore, and no flag
to indicate they are different.  This is confusing.  And usually people
who need check the elf header or read the content of kcore will check
memory ranges.  Two program segments which are the same are unnecessary.

So check if the modules range is equal to vmalloc range.  If so, just skip
adding the modules range.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 58cb6548

fs/proc/kcore.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -610,9 +610,11 @@ static void __init proc_kcore_text_init(void)
		struct kcore_list kcore_modules;
		static void __init add_modules_range(void)
		{
		if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
		kclist_add(&kcore_modules, (void *)MODULES_VADDR,
		MODULES_END - MODULES_VADDR, KCORE_VMALLOC);
		}
		}
		#else
		static void __init add_modules_range(void)
		{

Admin message