Commit bf389cab authored May 13, 2016 by Jiri Slaby Committed by Marcel Holtmann May 13, 2016

Bluetooth: fix power_on vs close race



With all the latest fixes applied, I am still able to reproduce this
(and other) warning(s):
WARNING: CPU: 1 PID: 19684 at ../kernel/workqueue.c:4092 destroy_workqueue+0x70a/0x770()
...
Call Trace:
 [<ffffffff819fee81>] ? dump_stack+0xb3/0x112
 [<ffffffff8117377e>] ? warn_slowpath_common+0xde/0x140
 [<ffffffff811ce68a>] ? destroy_workqueue+0x70a/0x770
 [<ffffffff811739ae>] ? warn_slowpath_null+0x2e/0x40
 [<ffffffff811ce68a>] ? destroy_workqueue+0x70a/0x770
 [<ffffffffa0c944c9>] ? hci_unregister_dev+0x2a9/0x720 [bluetooth]
 [<ffffffffa0b301db>] ? vhci_release+0x7b/0xf0 [hci_vhci]
 [<ffffffffa0b30160>] ? vhci_flush+0x50/0x50 [hci_vhci]
 [<ffffffff8117cd73>] ? do_exit+0x863/0x2b90

This is due to race present in the hci_unregister_dev path.
hdev->power_on work races with hci_dev_do_close. One tries to open,
the other tries to close, leading to warning like the above. (Another
example is a warning in kobject_get or kobject_put depending on who
wins the race.)

Fix this by switching those two racers to ensure hdev->power_on never
triggers while hci_dev_do_close is in progress.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent ed7cbbce

net/bluetooth/hci_core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3139,10 +3139,10 @@ void hci_unregister_dev(struct hci_dev *hdev)
		list_del(&hdev->list);
		write_unlock(&hci_dev_list_lock);

		hci_dev_do_close(hdev);

		cancel_work_sync(&hdev->power_on);

		hci_dev_do_close(hdev);

		if (!test_bit(HCI_INIT, &hdev->flags) &&
		!hci_dev_test_flag(hdev, HCI_SETUP) &&
		!hci_dev_test_flag(hdev, HCI_CONFIG)) {

Admin message