Commit bf361231 authored May 09, 2019 by Richard Guy Briggs Committed by Paul Moore May 23, 2019

audit: add saddr_fam filter field

Provide a method to filter out sockaddr and bind calls by network
address family.

Existing SOCKADDR records are listed for any network activity.
Implement the AUDIT_SADDR_FAM field selector to be able to classify or
limit records to specific network address families, such as AF_INET or
AF_INET6.

An example of a network record that is unlikely to be useful and flood
the logs:

type=SOCKADDR msg=audit(07/27/2017 12:18:27.019:845) : saddr={ fam=local
path=/var/run/nscd/socket }
type=SYSCALL msg=audit(07/27/2017 12:18:27.019:845) : arch=x86_64
syscall=connect success=no exit=ENOENT(No such file or directory) a0=0x3
a1=0x7fff229c4980 a2=0x6e a3=0x6 items=1 ppid=3301 pid=6145 auid=sgrubb
uid=sgrubb gid=sgrubb euid=sgrubb suid=sgrubb fsuid=sgrubb egid=sgrubb
sgid=sgrubb fsgid=sgrubb tty=pts3 ses=4 comm=bash exe=/usr/bin/bash
subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
key=network-test

Please see the audit-testsuite PR at
https://github.com/linux-audit/audit-testsuite/pull/87
Please see the github issue
https://github.com/linux-audit/audit-kernel/issues/64
Please see the github issue for the accompanying userspace support
https://github.com/linux-audit/audit-userspace/issues/93



Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
[PM: merge fuzz in auditfilter.c]
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent ecc68904

include/uapi/linux/audit.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -281,6 +281,7 @@
		#define AUDIT_OBJ_GID 110
		#define AUDIT_FIELD_COMPARE 111
		#define AUDIT_EXE 112
		#define AUDIT_SADDR_FAM 113

		#define AUDIT_ARG0 200
		#define AUDIT_ARG1 (AUDIT_ARG0+1)

kernel/auditfilter.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -391,6 +391,7 @@ static int audit_field_valid(struct audit_entry entry, struct audit_field f)
		case AUDIT_SUBJ_CLR:
		case AUDIT_OBJ_LEV_LOW:
		case AUDIT_OBJ_LEV_HIGH:
		case AUDIT_SADDR_FAM:
		/* bit ops are only useful on syscall args */
		if (f->op == Audit_bitmask \|\| f->op == Audit_bittest)
		return -EINVAL;
		@@ -438,6 +439,10 @@ static int audit_field_valid(struct audit_entry entry, struct audit_field f)
		if (f->val > AUDIT_MAX_FIELD_COMPARE)
		return -EINVAL;
		break;
		case AUDIT_SADDR_FAM:
		if (f->val >= AF_MAX)
		return -EINVAL;
		break;
		default:
		break;
		}

kernel/auditsc.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -615,6 +615,11 @@ static int audit_filter_rules(struct task_struct *tsk,
		case AUDIT_LOGINUID_SET:
		result = audit_comparator(audit_loginuid_set(tsk), f->op, f->val);
		break;
		case AUDIT_SADDR_FAM:
		if (ctx->sockaddr)
		result = audit_comparator(ctx->sockaddr->ss_family,
		f->op, f->val);
		break;
		case AUDIT_SUBJ_USER:
		case AUDIT_SUBJ_ROLE:
		case AUDIT_SUBJ_TYPE:

Admin message