Commit bf1cafa1 authored by Julia Lawall's avatar Julia Lawall Committed by Lee Jones
Browse files

mfd: kempld-core: Constify variables that point to const structure 

Add const to the declaration of various local variables of type
kempld_platform_data for which the referenced value is always only
dereferenced or passed to a const parameter, to record the fact that
kempld_platform_data_generic is declared as const.

The semantic match that finds this issue is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r@
identifier i,j;
@@
const struct i j = { ... };

@ok@
identifier r.i;
position p;
@@
const struct i@p *

@@
identifier r.i;
position p != ok.p;
@@
* struct i@p *
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent e5ff19cf

drivers/mfd/kempld-core.c

+8 −7
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static struct platform_device *kempld_pdev; 


static int kempld_create_platform_device(const struct dmi_system_id *id)

{

	struct kempld_platform_data *pdata = id->driver_data;

	const struct kempld_platform_data *pdata = id->driver_data;

	int ret;



	kempld_pdev = platform_device_alloc("kempld", -1);
@@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(kempld_write32); 
 */

void kempld_get_mutex(struct kempld_device_data *pld)

{

	struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);

	const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);



	mutex_lock(&pld->lock);

	pdata->get_hardware_mutex(pld);
@@ -272,7 +272,7 @@ EXPORT_SYMBOL_GPL(kempld_get_mutex); 
 */

void kempld_release_mutex(struct kempld_device_data *pld)

{

	struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);

	const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);



	pdata->release_hardware_mutex(pld);

	mutex_unlock(&pld->lock);
@@ -290,7 +290,7 @@ EXPORT_SYMBOL_GPL(kempld_release_mutex); 
static int kempld_get_info(struct kempld_device_data *pld)

{

	int ret;

	struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);

	const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);

	char major, minor;



	ret = pdata->get_info(pld);
@@ -332,7 +332,7 @@ static int kempld_get_info(struct kempld_device_data *pld) 
 */

static int kempld_register_cells(struct kempld_device_data *pld)

{

	struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);

	const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);



	return pdata->register_cells(pld);

}
@@ -444,7 +444,8 @@ static int kempld_detect_device(struct kempld_device_data *pld) 


static int kempld_probe(struct platform_device *pdev)

{

	struct kempld_platform_data *pdata = dev_get_platdata(&pdev->dev);

	const struct kempld_platform_data *pdata =

		dev_get_platdata(&pdev->dev);

	struct device *dev = &pdev->dev;

	struct kempld_device_data *pld;

	struct resource *ioport;
@@ -476,7 +477,7 @@ static int kempld_probe(struct platform_device *pdev) 
static int kempld_remove(struct platform_device *pdev)

{

	struct kempld_device_data *pld = platform_get_drvdata(pdev);

	struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);

	const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);



	sysfs_remove_group(&pld->dev->kobj, &pld_attr_group);

CRA Git | Maintained and supported by SUSTech CRA and CCSE