Commit bf173ca9 authored Oct 12, 2018 by Steven Rostedt (VMware)

tracing: probeevent: Fix uninitialized used of offset in parse args

Dan's smatch utility found an uninitialized use of offset in a path in
parse_probe_args(). Unless an offset is specifically specified for commands
that allow them, it should default to zero.

Link: http://lkml.kernel.org/r/20181012134246.5doqaobxunlqqs53@mwanda

Fixes: 53305928 ("tracing: probeevent: Introduce new argument fetching code")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com> (smatch)
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent a6682814

kernel/trace/trace_probe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -209,7 +209,7 @@ parse_probe_arg(char arg, const struct fetch_type type,
		{
		struct fetch_insn code = pcode;
		unsigned long param;
		long offset;
		long offset = 0;
		char *tmp;
		int ret = 0;

Admin message