Commit bf0e5013 authored Dec 10, 2019 by Florian Fainelli Committed by Jens Axboe Dec 25, 2019

ata: ahci_brcm: Add missing clock management during recovery



The downstream implementation of ahci_brcm.c did contain clock
management recovery, but until recently, did that outside of the
libahci_platform helpers and this was unintentionally stripped out while
forward porting the patch upstream.

Add the missing clock management during recovery and sleep for 10
milliseconds per the design team recommendations to ensure the SATA PHY
controller and AFE have been fully quiesced.

Fixes: eb73390a ("ata: ahci_brcm: Recover from failures to identify devices")
Cc: stable@vger.kernel.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 1a3d78cb

drivers/ata/ahci_brcm.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -274,6 +274,13 @@ static unsigned int brcm_ahci_read_id(struct ata_device *dev,
		/* Perform the SATA PHY reset sequence */
		brcm_sata_phy_disable(priv, ap->port_no);

		/* Reset the SATA clock */
		ahci_platform_disable_clks(hpriv);
		msleep(10);

		ahci_platform_enable_clks(hpriv);
		msleep(10);

		/* Bring the PHY back on */
		brcm_sata_phy_enable(priv, ap->port_no);

Admin message