gpio/aspeed-sgpio: don't enable all interrupts by default (bf0d394e) · Commits · 戴 / test

Currently, the IRQ setup for the SGPIO driver enables all interrupts in dual-edge trigger mode. Since the default handler is handle_bad_irq, any state change on input GPIOs will trigger bad IRQ warnings. This change applies sensible IRQ defaults: single-edge trigger, and all IRQs disabled. Signed-off-by:

Jeremy Kerr <jk@codeconstruct.com.au> Fixes: ("gpio: aspeed: Add SGPIO driver") Reviewed-by:

Joel Stanley <joel@jms.id.au> Acked-by:

Andrew Jeffery <andrew@aj.id.au> Signed-off-by:

Bartosz Golaszewski <bgolaszewski@baylibre.com>

drivers/gpio/gpio-aspeed-sgpio.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -452,17 +452,15 @@ static int aspeed_sgpio_setup_irqs(struct aspeed_sgpio *gpio,
		irq->parents = &gpio->irq;
		irq->num_parents = 1;

		/* set IRQ settings and Enable Interrupt */
		/* Apply default IRQ settings */
		for (i = 0; i < ARRAY_SIZE(aspeed_sgpio_banks); i++) {
		bank = &aspeed_sgpio_banks[i];
		/* set falling or level-low irq */
		iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type0));
		/* trigger type is edge */
		iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type1));
		/* dual edge trigger mode. */
		iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_type2));
		/* enable irq */
		iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_enable));
		/* single edge trigger */
		iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type2));
		}

		return 0;

Admin message