Commit bf0239a9 authored by Peter Pan(潘卫平)'s avatar Peter Pan(潘卫平) Committed by David S. Miller
Browse files

bonding:delete a dereference before check



Dan Carpenter found that there was a dereference before a check,
added in 56d00c67(bonding:delete lacp_fast from ad_bond_info).

Signed-off-by: default avatarWeiping Pan <panweiping3@gmail.com>
Signed-off-by: default avatarJay Vosburgh <fubar@us.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@conan.davemloft.net>
parent 081b1b1b
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -1900,7 +1900,6 @@ void bond_3ad_initialize(struct bonding *bond, u16 tick_resolution)
int bond_3ad_bind_slave(struct slave *slave)
{
	struct bonding *bond = bond_get_bond_by_slave(slave);
	int lacp_fast = bond->params.lacp_fast;
	struct port *port;
	struct aggregator *aggregator;

@@ -1916,7 +1915,7 @@ int bond_3ad_bind_slave(struct slave *slave)
		// port initialization
		port = &(SLAVE_AD_INFO(slave).port);

		ad_initialize_port(port, lacp_fast);
		ad_initialize_port(port, bond->params.lacp_fast);

		port->slave = slave;
		port->actor_port_number = SLAVE_AD_INFO(slave).id;