Commit befb1b3c authored Sep 19, 2018 by Reinette Chatre Committed by Thomas Gleixner Sep 28, 2018

perf/core: Add sanity check to deal with pinned event failure



It is possible that a failure can occur during the scheduling of a
pinned event. The initial portion of perf_event_read_local() contains
the various error checks an event should pass before it can be
considered valid. Ensure that the potential scheduling failure
of a pinned event is checked for and have a credible error.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: fenghua.yu@intel.com
Cc: tony.luck@intel.com
Cc: acme@kernel.org
Cc: gavin.hindman@intel.com
Cc: jithu.joseph@intel.com
Cc: dave.hansen@intel.com
Cc: hpa@zytor.com
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/6486385d1f30336e9973b24c8c65f5079543d3d3.1537377064.git.reinette.chatre@intel.com

parent c307aaf3

kernel/events/core.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -3935,6 +3935,12 @@ int perf_event_read_local(struct perf_event event, u64 value,
		goto out;
		}

		/* If this is a pinned event it must be running on this CPU */
		if (event->attr.pinned && event->oncpu != smp_processor_id()) {
		ret = -EBUSY;
		goto out;
		}

		/*
		* If the event is currently on this CPU, its either a per-task event,
		* or local to this CPU. Furthermore it means its ACTIVE (otherwise

Admin message